Read scaled output values using set gyro and acceleromter ranges #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsaase
changed the title
eldruin
reviewed
May 2, 2024
There was a problem hiding this comment.
Looks good to me, thank you!
For the tests, I would like to see tests for the set_accel_range and set_gyro_range so that it is checked that providing each variant results in an adequate register write.
I think you can copy the code highlighted here into a new range.rs file and adapt it.
For getting the data scaled, I would like to have a test that looks like this one but the values are scaled according to the ranges set.
|
I addressed your review comments and also the the ones from #8. I think it makes sense to let this PR replace the other one. |
|
Thank you! I have merged this now and released it in version 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #8 to add function that returns the scaled output values for the set gyro and accelerometer range.
I don't fully understand the testing setup used in this repo so I didn't add any tests. I'm happy to add some if you can give some guidance on what you want tested.
Closes #8