fix(client): Use execute Capacitor driver API to fix parsing issue
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfstef
added a commit
that referenced
this pull request
Mar 14, 2024
…1052) Using the `execute` API rather than the `run` one for when no bind values are provided as it has less pre-processing and solves a parsing issue that `run` has for statements like `BEGIN` and `ROLLBACK`. Not strictly necessary but provides an immediate solution to a bug that is blocking the use of this driver on Android without requiring changes from the driver side. See this issue: capacitor-community/sqlite#526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
executeAPI rather than therunone for when no bind values are provided as it has less pre-processing and solves a parsing issue thatrunhas for statements likeBEGINandROLLBACK.Not strictly necessary but provides an immediate solution to a bug that is blocking the use of this driver on Android without requiring changes from the driver side.
See this issue: capacitor-community/sqlite#526