refactor: remove arrow from SV parser #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
reviewed
Dec 22, 2023
yujia21
force-pushed
the
6135-remove-arrow-SV
branch
from
a5d90eb
to
ec10c8a
Compare
VIKTORVAV99
approved these changes
Jan 6, 2024
ghost
pushed a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
6135
Description
Removes arrow module from parser, replacing with
datetime.Preview
Double check
poetry run test_parser "zone_key"pnpx prettier --write .andpoetry run formatto format my changes.