Skip to content

Commit c4744af

Browse files
committed
fix(deployment): disable automatic detection for S3
Close #1334
1 parent 3ee8a59 commit c4744af

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

docs/Publishing Artifacts.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b
8080

8181
If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`.
8282
If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`.
83-
If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`.
8483

8584
Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS).
8685

packages/electron-builder-http/src/publishOptions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Can be specified in the [config](https://github.com/electron-userland/electron-b
77
88
If `GH_TOKEN` is set — defaults to `[{provider: "github"}]`.
99
If `BT_TOKEN` is set and `GH_TOKEN` is not set — defaults to `[{provider: "bintray"}]`.
10-
If `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` are set and neither `GH_TOKEN` and `BT_TOKEN` are set — defaults to `[{provider: "s3"}]`.
1110
1211
Array of option objects. Order is important — first item will be used as a default auto-update server on Windows (NSIS).
1312

packages/electron-builder/src/publish/PublishManager.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,9 +368,6 @@ export async function getPublishConfigs(packager: PlatformPackager<any>, targetS
368368
else if (!isEmptyOrSpaces(process.env.BT_TOKEN)) {
369369
serviceName = "bintray"
370370
}
371-
else if (!isEmptyOrSpaces(process.env.AWS_ACCESS_KEY_ID) && !isEmptyOrSpaces(process.env.AWS_SECRET_ACCESS_KEY)) {
372-
serviceName = "s3"
373-
}
374371

375372
if (serviceName != null) {
376373
debug(`Detect ${serviceName} as publish provider`)

0 commit comments

Comments
 (0)