Skip to content

Commit c7e07cc

Browse files
committed
fix(electron-updater): remove escaping of package-path arg - node escapes it properly
1 parent 7fc9a29 commit c7e07cc

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"dependencies": {
3232
"7zip-bin": "~4.0.2",
3333
"@types/is-ci": "^1.1.0",
34-
"app-builder-bin": "2.1.3",
34+
"app-builder-bin": "2.1.4",
3535
"archiver": "^3.0.0",
3636
"async-exit-hook": "^2.0.1",
3737
"bluebird-lst": "^1.0.5",

packages/app-builder-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"homepage": "https://github.com/electron-userland/electron-builder",
4343
"dependencies": {
4444
"7zip-bin": "~4.0.2",
45-
"app-builder-bin": "2.1.3",
45+
"app-builder-bin": "2.1.4",
4646
"async-exit-hook": "^2.0.1",
4747
"bluebird-lst": "^1.0.5",
4848
"chromium-pickle-js": "^0.2.0",

packages/builder-util/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"out"
1212
],
1313
"dependencies": {
14-
"app-builder-bin": "2.1.3",
14+
"app-builder-bin": "2.1.4",
1515
"temp-file": "^3.1.3",
1616
"fs-extra-p": "^4.6.1",
1717
"is-ci": "^1.2.1",

packages/electron-updater/src/NsisUpdater.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,19 +88,19 @@ export class NsisUpdater extends BaseUpdater {
8888
}
8989

9090
protected async doInstall(installerPath: string, isSilent: boolean, isForceRunAfter: boolean): Promise<boolean> {
91-
const args = ["/updated"]
91+
const args = ["--updated"]
9292
if (isSilent) {
9393
args.push("/S")
9494
}
9595

9696
if (isForceRunAfter) {
97-
args.push("/force-run")
97+
args.push("--force-run")
9898
}
9999

100100
const packagePath = this.downloadedUpdateHelper.packageFile
101101
if (packagePath != null) {
102102
// only = form is supported
103-
args.push(`"/package-file=${packagePath}"`)
103+
args.push(`--package-file=${packagePath}`)
104104
}
105105

106106
const spawnOptions: any = {

0 commit comments

Comments
 (0)