feat: Don't build when CI run is a pull request

Close #1354

Author: develar

packages/electron-builder-util/src/util.ts

@@ -294,4 +294,14 @@ export function getPlatformIconFileName(value: string | null | undefined, isMac:
   }
 
   return value.replace(isMac ? ".ico" : ".icns", isMac ? ".icns" : ".ico")
+}
+
+export function isPullRequest() {
+  // TRAVIS_PULL_REQUEST is set to the pull request number if the current job is a pull request build, or false if it’s not.
+  function isSet(value: string) {
+    // value can be or null, or empty string
+    return value && value !== "false"
+  }
+
+  return isSet(process.env.TRAVIS_PULL_REQUEST) || isSet(process.env.CI_PULL_REQUEST) || isSet(process.env.CI_PULL_REQUESTS)
 }

packages/electron-builder/src/macPackager.ts

@@ -1,6 +1,6 @@
 import BluebirdPromise from "bluebird-lst"
 import { Arch, DIR_TARGET, Platform, Target } from "electron-builder-core"
-import { exec } from "electron-builder-util"
+import { exec, isPullRequest } from "electron-builder-util"
 import { deepAssign } from "electron-builder-util/out/deepAssign"
 import { log, task, warn } from "electron-builder-util/out/log"
 import { signAsync, SignOptions } from "electron-macos-sign"
@@ -115,6 +115,10 @@ export default class MacPackager extends PlatformPackager<MacOptions> {
       warn("macOS application code signing is supported only on macOS, skipping.")
       return
     }
+    if (isPullRequest()) {
+      log("Current build is a part of pull request, code signing will be skipped")
+      return
+    }
 
     const keychainName = (await this.codeSigningInfo).keychainName
     const isMas = masOptions != null

packages/electron-builder/src/publish/PublishManager.ts

@@ -3,7 +3,7 @@ import { createHash } from "crypto"
 import { Arch, Platform, Target } from "electron-builder-core"
 import { CancellationToken } from "electron-builder-http/out/CancellationToken"
 import { GenericServerOptions, GithubOptions, githubUrl, PublishConfiguration, PublishProvider, S3Options, s3Url, UpdateInfo, VersionInfo } from "electron-builder-http/out/publishOptions"
-import { asArray, debug, isEmptyOrSpaces } from "electron-builder-util"
+import { asArray, debug, isEmptyOrSpaces, isPullRequest } from "electron-builder-util"
 import { log } from "electron-builder-util/out/log"
 import { throwError } from "electron-builder-util/out/promise"
 import { HttpPublisher, PublishContext, Publisher, PublishOptions } from "electron-publish"
@@ -410,16 +410,6 @@ function sha256(file: string) {
   })
 }
 
-function isPullRequest() {
-  // TRAVIS_PULL_REQUEST is set to the pull request number if the current job is a pull request build, or false if it’s not.
-  function isSet(value: string) {
-    // value can be or null, or empty string
-    return value && value !== "false"
-  }
-
-  return isSet(process.env.TRAVIS_PULL_REQUEST) || isSet(process.env.CI_PULL_REQUEST) || isSet(process.env.CI_PULL_REQUESTS)
-}
-
 function isSuitableWindowsTarget(target: Target) {
   return target.name === "nsis" || target.name.startsWith("nsis-")
 }