feat(nsis): custom uninstall application icon

develar · develar · commit e4e5cc7ab511 · 2017-05-27T10:58:06.000+02:00
Close #1585
diff --git a/packages/electron-builder/src/targets/nsis.ts b/packages/electron-builder/src/targets/nsis.ts
@@ -361,7 +361,9 @@ export class NsisTarget extends Target {
 
     const uninstallerIcon = await packager.getResource(options.uninstallerIcon, "uninstallerIcon.ico")
     if (uninstallerIcon != null) {
+      // we don't need to copy MUI_UNICON (defaults to app icon), so, we have 2 defines
       defines.UNINSTALLER_ICON = uninstallerIcon
+      defines.MUI_UNICON = uninstallerIcon
     }
   }
 
diff --git a/test/out/windows/__snapshots__/portableTest.js.snap b/test/out/windows/__snapshots__/portableTest.js.snap
@@ -15,10 +15,6 @@ Object {
 exports[`portable 1`] = `
 Object {
   "win": Array [
-    Object {
-      "arch": null,
-      "file": "latest.yml",
-    },
     Object {
       "arch": 1,
       "file": "Test App ßW Setup 1.1.0.exe",

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,9 @@ export class NsisTarget extends Target {`
`361`	`361`
`362`	`362`	`const uninstallerIcon = await packager.getResource(options.uninstallerIcon, "uninstallerIcon.ico")`
`363`	`363`	`if (uninstallerIcon != null) {`
	`364`	`+ // we don't need to copy MUI_UNICON (defaults to app icon), so, we have 2 defines`
`364`	`365`	`defines.UNINSTALLER_ICON = uninstallerIcon`
	`366`	`+ defines.MUI_UNICON = uninstallerIcon`
`365`	`367`	`}`
`366`	`368`	`}`
`367`	`369`