fix: trim the whole string, otherwise detection of windows-like path is not robust

develar · develar · commit e63e8fa9bf2d · 2017-05-30T12:28:35.000+02:00
Close #1596
diff --git a/packages/electron-builder/src/codeSign.ts b/packages/electron-builder/src/codeSign.ts
@@ -19,6 +19,8 @@ export interface CodeSigningInfo {
 }
 
 export async function downloadCertificate(urlOrBase64: string, tmpDir: TmpDir, currentDir: string): Promise<string> {
+  urlOrBase64 = urlOrBase64.trim()
+
   let file: string | null = null
   if ((urlOrBase64.length > 3 && urlOrBase64[1] === ":") || urlOrBase64.startsWith("/") || urlOrBase64.startsWith(".")) {
     file = urlOrBase64
@@ -46,7 +48,7 @@ export async function downloadCertificate(urlOrBase64: string, tmpDir: TmpDir, c
     }
   }
 
-  file = path.resolve(currentDir, file.trim())
+  file = path.resolve(currentDir, file)
   const stat = await statOrNull(file)
   if (stat == null) {
     throw new Error(`${file} doesn't exist`)

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ export interface CodeSigningInfo {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`export async function downloadCertificate(urlOrBase64: string, tmpDir: TmpDir, currentDir: string): Promise<string> {`
	`22`	`+ urlOrBase64 = urlOrBase64.trim()`
	`23`	`+`
`22`	`24`	`let file: string \| null = null`
`23`	`25`	`if ((urlOrBase64.length > 3 && urlOrBase64[1] === ":") \|\| urlOrBase64.startsWith("/") \|\| urlOrBase64.startsWith(".")) {`
`24`	`26`	`file = urlOrBase64`
`@@ -46,7 +48,7 @@ export async function downloadCertificate(urlOrBase64: string, tmpDir: TmpDir, c`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`
`49`		`- file = path.resolve(currentDir, file.trim())`
	`51`	`+ file = path.resolve(currentDir, file)`
`50`	`52`	`const stat = await statOrNull(file)`
`51`	`53`	`if (stat == null) {`
`52`	`54`	throw new Error(`${file} doesn't exist`)