allow delegate to handle file and color chooser

[deepak1556]

Fixes electron/electron#6156

A side note,

• should WebDialogHelper::EnumerateDirectory required to be enumerate over DIRECTORIES, INCLUDE_DOT_DOT when its not recursive ?
• The current implementation causes render to terminate with RVH_CAN_ACCESS_FILES_OF_PAGE_STATE because of INCLUDE_DOT_DOT in the result.
• Can we make the enumeration async using net::DirectoryLister or is the current implementation fine ?

[zcbenz]

👍

[zcbenz]

should WebDialogHelper::EnumerateDirectory required to be enumerate over DIRECTORIES, INCLUDE_DOT_DOT when its not recursive ?

The current implementation causes render to terminate with RVH_CAN_ACCESS_FILES_OF_PAGE_STATE because of INCLUDE_DOT_DOT in the result.

We should probably follow what Chromium does.

Can we make the enumeration async using net::DirectoryLister or is the current implementation fine ?

It would be much better.

So far no one actually complained about our dialog implementation, we can maybe wait unless someone complains.