set dock state using devtools dockController #254

Merged
merged 1 commit into from Oct 10, 2016

Projects

None yet

3 participants

@deepak1556
Member

settings query param was removed in https://codereview.chromium.org/2177983004 , hence our dock state was not respected. We now directly set the dock state using WebInspector.dockController.setDockSide api since it seems more reliable.

Fixes electron/electron#7503

@zcbenz
Contributor
zcbenz commented Oct 10, 2016

👍

@zcbenz zcbenz merged commit abae71b into electron:master Oct 10, 2016
@kevinsawicki
Contributor

Are you able to update the dock side and have it persist across relaunches/reopens?

I'm seeing it go to the right side every time using the default app. Even after I set it to go to the bottom, then close it, it opens the next time on the right side again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment