setContentProtection not working on macOS #19880

veemex · 2019-08-22T07:50:42Z

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

Electron Version:
6.0.x , 7.0.x
Operating System:
- macOS 10.14 , macos 10.15
Last Known Working Electron version:
*4.x.x

Expected Behavior

The function {browserwindow}.setContentProtection(true) , should make the app unrecordable for "Electron desktopCapturer" module.

Actual Behavior

It does not work .

To Reproduce

Make a simple blank app, setContentProtection of the browserWindow, capture the desktop stream using the desktopCapturer module and show it on a canvas.

sofianguy · 2019-08-27T20:09:44Z

Thank you for taking the time to report this issue and helping to make Electron better.

Would it be possible for you to fork electron-quick-start for a small app that reproduces the issue by itself?

Standalone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

veemex · 2019-08-29T10:00:45Z

@sofianguy , yes i will post shortly the link . Thanks !

veemex · 2019-08-29T10:14:45Z

@sofianguy , here you can see it https://github.com/veemex/electron-quick-start "git clone https://github.com/veemex/electron-quick-start setContentProtectionBug" :)

loc · 2019-09-06T22:42:51Z

It's not working because WebRTC recently switched to a CGDisplayStream-based capturer, which doesn't respect NSWindowSharingNone. Here's the relevant issue https://bugs.chromium.org/p/webrtc/issues/detail?id=8652

AFAICT the only option is for Electron to expose SetExcludedWindow of the DesktopCapturer instance that WebRTC is holding. We'd also probably want to patch it to allow you to exclude multiple windows. But even if we do that work, Windows still won't work, as the DXGI capturer doesn't support excluded windows 😕

akkhilaysh · 2019-10-24T00:33:51Z

Can we expand on this? I'm looking for answers to protect my electron app content from screen shares and remote desktop software.

veemex · 2020-01-13T11:41:35Z

Is this going to be have any fixes? Also does someone recommend a way to use another capturer for the MacOS or another way of achieving this effect of not showing the app during a screen recording that can be converted to a media-stream ? Thanks !

sajjanbalar · 2020-04-23T05:06:14Z

Is there any fix for this now? Google Meets can capture my screen even if the screen protection is set to true. I need to urgently fix this! My electron app is valued only because it can't be seen on screen shares!

sajjanbalar · 2020-04-23T06:43:27Z

It's not working because WebRTC recently switched to a CGDisplayStream-based capturer, which doesn't respect NSWindowSharingNone. Here's the relevant issue https://bugs.chromium.org/p/webrtc/issues/detail?id=8652

AFAICT the only option is for Electron to expose SetExcludedWindow of the DesktopCapturer instance that WebRTC is holding. We'd also probably want to patch it to allow you to exclude multiple windows. But even if we do that work, Windows still won't work, as the DXGI capturer doesn't support excluded windows 😕

But since windows has the affinity setting, shouldn't it work with that? Also, what ID do I pass to SetExcudedWindow to fix this?

CapOM · 2020-04-23T07:08:35Z

On Mac, pass the chromium flag --disable-features=IOSurfaceCapturer ( from the app just add: app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer') )

sajjanbalar · 2020-04-24T03:26:00Z

On Mac, pass the chromium flag --disable-features=IOSurfaceCapturer ( from the app just add: app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer') )

And what if I want my window to not be seen by other Screen Recording software? This used to work well with setContentProtection() but now any screenshare from Chrome Mac shows the window. Will this help with that? Or will I have wait for electron to change to setExcludedWindow?

CapOM · 2020-04-24T03:58:02Z

Yes, to have setContentProtection working again you need to pass the above flag.

sajjanbalar · 2020-04-24T05:47:22Z

Yes, to have setContentProtection working again you need to pass the above flag.

This doesn't seem to work. On Mac OS, Chrome (Google meets specifically) screen share, my window is exposed.

CapOM · 2020-04-24T06:11:11Z

Probably Google meets ignores all chromium flags. What I meant has to be set for an electron based application on which you have control on the build, so calling app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer') in the main.js for example

sajjanbalar · 2020-04-24T06:47:15Z

Probably Google meets ignores all chromium flags. What I meant has to be set for an electron based application on which you have control on the build, so calling app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer') in the main.js for example

Yeah I did that, didn't help. I need Google Chrome (Google meets screen share etc. i.e. webrtc capturer) to not record my electron app which has sensitive content. I was using setContentProtection() to do that. This works fine with firefox on Mac and any browser on Windows, but the screen capturer in Mac chrome is not respecting setContentProtection, I need a way around that.

CapOM · 2020-04-24T07:35:42Z

Oh I see you would need to pass --disable-features=IOSurfaceCapturer to Google Chrome but that's not possible. I thought you were capturing the screen with your app (electron's desktopCapturer)

sajjanbalar · 2020-04-24T11:40:51Z

Oh I see you would need to pass --disable-features=IOSurfaceCapturer to Google Chrome but that's not possible. I thought you were capturing the screen with your app (electron's desktopCapturer)

So, as suggested here : https://bugs.chromium.org/p/webrtc/issues/detail?id=8652#c45 can we use webrtc::DesktopCapturer::SetExcludedWindow instead of relying on NSWindowSharingNone for mac?

CapOM · 2020-04-24T16:50:39Z

@sajjanbalar there is no solution for what you are trying to do since you do not have control to Google Chrome or Google Meeting. The webrtc::DesktopCapturer::SetExcludedWindow API would to use when you setup the screen capture from your own app.
I think you miss interpreted the description on this ticket #19880

sajjanbalar · 2020-04-24T17:14:17Z

@sajjanbalar there is no solution for what you are trying to do since you do not have control to Google Chrome or Google Meeting. The webrtc::DesktopCapturer::SetExcludedWindow API would to use when you setup the screen capture from your own app.
I think you miss interpreted the description on this ticket #19880

Oh, but setContentProtection works well in windows, also in Firefox mac. I guess what I am seeking is a way to tell the mac os chrome browser to respect the windows choice to not get captured. No way to do that?

oalfroukh · 2023-06-08T07:49:26Z

That's one of the reasons ScreenCaptureKitMac isn't enabled by default yet 😅 still some bugs to work through

OK, thanks, So we will wait to enable it by default to avoid all the side effects 😁

mtshv · 2023-07-26T15:55:31Z

Hello Electron team,
This issue is impacting our project as we rely on this function for our application.

Could you kindly provide us with any updates on this issue and possibly a timeline for resolution? This would be greatly beneficial in helping us manage our project's timeline and expectations.

Thank you for your time and consideration :)

flyyuan · 2023-08-19T19:08:24Z

The setContentProtection API is based on the NSWindow's sharingType on MacOS.
It doesn't work because NSWindowSharingNone only works on a single window, not on a screen.
I think we need a new API to protect content during screen sharing? The API overflows or hides some content.

cgri1 · 2023-08-24T07:16:49Z

Is there any progress on this problem?

padmakant-baloji · 2023-08-30T07:05:04Z

Is there any workaround for this problem?

In electron utils 2.0.15 we mark them as protected content, but on macOS WebRTC uses a low level API which sidesteps that. An extra command line argument is passed to fix that. See: electron/electron#19880

This fixes the AoT and screensharing tracker from being captured based on electron/electron#19880

foxxy432 · 2023-09-05T22:05:45Z

It is ignored by Microsoft because of incompatibilities BUT you can use my fork: https://github.com/lnxx-kernel/electron_touch

cgri1 · 2023-10-05T13:23:52Z

Is there any progress on this problem?

derekcicerone · 2023-10-05T13:28:57Z

We were able to get this working if:

setContentProtection(true) is called on a BrowserWindow prior to starting the screen share
ScreenCaptureKit is enabled via app.commandLine.appendSwitch("enable-features", "ScreenCaptureKitMac"); (before the app is ready)

ScreenCaptureKit support is still being developed in Chromium so I'd only recommend doing this for Electron v26+.

padmakant-baloji · 2023-11-29T10:18:05Z

Hello Electron Team,
This is impacting our electron application
Is there any fix or workaround for this?

dretax · 2023-12-01T11:42:28Z

https://bugs.chromium.org/p/chromium/issues/detail?id=1309653
chromium/chromium@843de71

@MarshallOfSound based on these findings, and the versioning checks, It should be safe to enable this feature rn?
Saw the feature was also enabled by default in electron.

dretax · 2023-12-05T16:21:58Z

ScreenCaptureKitMac

@derekcicerone
I've tried the following things mentioned btw on electron 27 fiddler, but I was unable to get it to work. Am I missing something? (Hence the option was removed from a github commit in chromium, I assume something else needs to be enabled maybe?)

divyanshunegi · 2024-01-31T09:26:10Z

I have made it work with this flag

app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer,DesktopCaptureMacV2')

and setContentProtection(true)

BUT make sure you are on electron version 23.3.13 or less, latest version does not work, I am not sure why

flyyuan · 2024-01-31T09:26:37Z

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

saghul · 2024-01-31T11:10:34Z

Electron 20 is EOL, you shouldn't be using that or recommending it to anyone.

divyanshunegi · 2024-01-31T13:30:13Z

Electron 20 is EOL, you shouldn't be using that or recommending it to anyone.

@saghul I have been struggling with this issue for couple of days now, our app requires some windows to be ignored when screen recording, and the only solution which worked for me was downgrading electron to 23.3.13 as latest, above this setContentProtection flag does not work. I have posted the solution for someone who might be in similar situation as me, meanwhile looking for solutions to upgrade electron as well.

phwang4 · 2024-02-02T19:38:05Z

app.commandLine.appendSwitch("enable-features", "ScreenCaptureKitMac");
is causing the screen share to not work now for me. Anyone else seeing this?
After a few seconds I get the error
DOMException: Could not start video source

Here is a gist that shows this: https://gist.github.com/phwang4/655231b026fdedac408f430604dee0b8
This is mostly the same as fdlmdark's gist but with that new feature and upgraded to electron 28

If I disable that line the screen share will work again (although setContentProtection still doesn't work)
and like divyanshunegi mentioned, only downgrading to electron 23 makes the flag
app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer,DesktopCaptureMacV2')
actually work.

KlausMikhaelson · 2024-02-13T19:44:22Z

Hey @divyanshunegi, I have been trying the same for a while but it's not working for me, like I can still see the app while doing screen share on google meet, anyway you can share a demo project with it implemented ?

tbridgejc · 2024-02-14T15:25:46Z

Beginning with macOS 14.4, releasing in the next 30 days, the old CGDisplayStreamCreate methods are resulting in per-session alerts. What is the current plan to support ScreenCaptureKit in its place, @MarshallOfSound ? :)

ayushete02 · 2024-03-13T12:15:21Z

ScreenCaptureKitMac

@KlausMikhaelson I am facing the same issue, did you found some solution?

rakhee28 · 2024-04-19T11:22:11Z

any solution for protecting electron app while sharing entire screen on Zoom app for electron version v30.

Nantris · 2024-04-20T19:54:55Z

I'm also wondering if this issue has become a lost cause? In which case the docs really need updating. They already acknowledge it doesn't work on Linux and should specify the same for macOS.

rakhee28 · 2024-04-24T04:31:12Z

I tried some solution which is working intermediately app.commandLine.appendSwitch('disable-features', 'IOSurfaceCapturer,DesktopCaptureMacV2'). @divyanshunegi as you mentioned above, is this solution working for you in zoom entire screen sharing?
I can't say it is very solid and full proof solution, I need help for specifically version v30

akylkb · 2024-04-26T13:35:29Z

Hey, guys! I have come up with one solution for screen recording protection on MacOS. I found that the VTEncoderXPCService process starts when capturing the screen. And I wrote a function that periodically checks the list of processes.

You can check through Electron Fiddle:
https://gist.github.com/8f65a9c7285a9dcbcd1874415bb34d84

I checked on Ventura 13.0 (22A8380) and it works for me.
I will be glad if you share your experience in your version of os (Mojave, Catalina, BigSur, etc)

imbdb · 2024-07-07T04:29:20Z

Is there any solution for this without killing the screenshare process?

Can't we detect screenshare and blur the app? The blur should only be visible in screenshare and user should be able to see the app.

Nantris · 2024-08-06T21:30:52Z

Electron team doesn't really seem to care if their promised feature set breaks, as long as it worked once in the past. It's not good.

At least update the docs...

imbdb · 2024-08-07T00:14:12Z

@ansien I tried v24, the bug is still present on MacOS.

sofianguy added 6-0-x 7-0-x blocked/need-info ❌ Cannot proceed without more information bug 🪲 platform/macOS labels Aug 27, 2019

sofianguy removed the blocked/need-info ❌ Cannot proceed without more information label Aug 30, 2019

sofianguy added the 7-1-x label Nov 6, 2019

sofianguy added 6-1-x and removed 6-0-x labels Feb 19, 2020

schontz mentioned this issue Jun 20, 2023

[Bug]: contentProtection no longer working on macOS #38863

Closed

3 tasks

flyyuan mentioned this issue Aug 19, 2023

[Bug]: setContentProtection problem #39452

Closed

3 tasks

d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023

fix(screensharing) add DesktopCaptureMacV2 to disabled-features

8369da8

This fixes the AoT and screensharing tracker from being captured based on electron/electron#19880

setContentProtection not working on macOS #19880

setContentProtection not working on macOS #19880

Comments

veemex commented Aug 22, 2019 • edited Loading

Preflight Checklist

Issue Details

Expected Behavior

Actual Behavior

To Reproduce

sofianguy commented Aug 27, 2019

veemex commented Aug 29, 2019

veemex commented Aug 29, 2019

loc commented Sep 6, 2019

akkhilaysh commented Oct 24, 2019

veemex commented Jan 13, 2020

sajjanbalar commented Apr 23, 2020

sajjanbalar commented Apr 23, 2020

CapOM commented Apr 23, 2020

sajjanbalar commented Apr 24, 2020

CapOM commented Apr 24, 2020

sajjanbalar commented Apr 24, 2020

CapOM commented Apr 24, 2020 • edited Loading

sajjanbalar commented Apr 24, 2020

CapOM commented Apr 24, 2020

sajjanbalar commented Apr 24, 2020 • edited Loading

CapOM commented Apr 24, 2020 • edited Loading

sajjanbalar commented Apr 24, 2020

oalfroukh commented Jun 8, 2023

mtshv commented Jul 26, 2023

flyyuan commented Aug 19, 2023 • edited Loading

cgri1 commented Aug 24, 2023

padmakant-baloji commented Aug 30, 2023

foxxy432 commented Sep 5, 2023

cgri1 commented Oct 5, 2023

derekcicerone commented Oct 5, 2023 • edited Loading

padmakant-baloji commented Nov 29, 2023

dretax commented Dec 1, 2023 • edited Loading

dretax commented Dec 5, 2023 • edited Loading

divyanshunegi commented Jan 31, 2024 • edited Loading

flyyuan commented Jan 31, 2024 via email

saghul commented Jan 31, 2024

divyanshunegi commented Jan 31, 2024

phwang4 commented Feb 2, 2024

KlausMikhaelson commented Feb 13, 2024

tbridgejc commented Feb 14, 2024

ayushete02 commented Mar 13, 2024

rakhee28 commented Apr 19, 2024 • edited Loading

Nantris commented Apr 20, 2024

rakhee28 commented Apr 24, 2024 • edited Loading

akylkb commented Apr 26, 2024

imbdb commented Jul 7, 2024

Nantris commented Aug 6, 2024 • edited Loading

imbdb commented Aug 7, 2024

veemex commented Aug 22, 2019 •

edited

Loading

CapOM commented Apr 24, 2020 •

edited

Loading

sajjanbalar commented Apr 24, 2020 •

edited

Loading

CapOM commented Apr 24, 2020 •

edited

Loading

flyyuan commented Aug 19, 2023 •

edited

Loading

derekcicerone commented Oct 5, 2023 •

edited

Loading

dretax commented Dec 1, 2023 •

edited

Loading

dretax commented Dec 5, 2023 •

edited

Loading

divyanshunegi commented Jan 31, 2024 •

edited

Loading

rakhee28 commented Apr 19, 2024 •

edited

Loading

rakhee28 commented Apr 24, 2024 •

edited

Loading

Nantris commented Aug 6, 2024 •

edited

Loading