New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add crashesDirectory to crash reporter options #10453

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@bpasero
Contributor

bpasero commented Sep 7, 2017

This helps for electron.d.ts containing this property. See #10448

@MarshallOfSound MarshallOfSound merged commit 6ba3ee3 into electron:master Sep 7, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@joelsand

This comment has been minimized.

joelsand commented Oct 9, 2017

The docs say "(only used when the crash reporter is started via process.crashReporter.start)" - what does this mean? Is this different from using electron.crashReporter.start(...)? I'm having trouble getting the crashesDirectory to take affect for me.

@bpasero bpasero deleted the bpasero:fix-10448 branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment