Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add crashesDirectory to crash reporter options #10453

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Docs: add crashesDirectory to crash reporter options #10453

merged 1 commit into from
Sep 7, 2017

Conversation

bpasero
Copy link
Contributor

@bpasero bpasero commented Sep 7, 2017

This helps for electron.d.ts containing this property. See #10448

@MarshallOfSound MarshallOfSound merged commit 6ba3ee3 into electron:master Sep 7, 2017
@joelsand
Copy link

joelsand commented Oct 9, 2017

The docs say "(only used when the crash reporter is started via process.crashReporter.start)" - what does this mean? Is this different from using electron.crashReporter.start(...)? I'm having trouble getting the crashesDirectory to take affect for me.

@bpasero bpasero deleted the fix-10448 branch October 10, 2017 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpasero @joelsand @MarshallOfSound