Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-instructions-linux.md #10719

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
2 participants
@yunzhenhuan
Copy link
Contributor

yunzhenhuan commented Oct 9, 2017

No description provided.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 9, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@yunzhenhuan

This comment has been minimized.

Copy link
Contributor Author

yunzhenhuan commented Oct 9, 2017

Thanks

@zeke

zeke approved these changes Oct 9, 2017

@zeke zeke merged commit d7e5855 into electron:master Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Oct 9, 2017

Congrats on merging your first pull request! 🎉🎉🎉

@zeke

This comment has been minimized.

Copy link
Member

zeke commented Oct 9, 2017

Thanks for your contribution!

I wanted to let you know that we're working on a new system for translating Electron's docs. See the readme at electron/electron-i18n for info on how to get started, or you can jump right into translating at https://crowdin.com/project/electron

@yunzhenhuan yunzhenhuan deleted the yunzhenhuan:patch-1 branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.