New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Documentation: Add link to App User Model Id #11009

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
@felixrieseberg
Member

felixrieseberg commented Nov 3, 2017

Another tiny one-line fix I came across in our documentation.

@felixrieseberg felixrieseberg requested a review from electron/docs as a code owner Nov 3, 2017

@poiru

poiru approved these changes Nov 3, 2017

@MarshallOfSound MarshallOfSound merged commit 5e50a9a into master Nov 7, 2017

7 of 8 checks passed

electron-osx-x64 Build #5671 failed in 16 min
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5700 succeeded in 17 min
Details

@MarshallOfSound MarshallOfSound deleted the docs-aumi-link branch Nov 7, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 9, 2017

Member

We should test for these 🤔

Member

zeke commented Nov 9, 2017

We should test for these 🤔

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Nov 9, 2017

Member

@woorm do you know of a module that checks for [links] that don't have a corresponding definition? I forget what these are called in official Markdown parlance.

Member

zeke commented Nov 9, 2017

@woorm do you know of a module that checks for [links] that don't have a corresponding definition? I forget what these are called in official Markdown parlance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment