Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle remote exception #12694

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Conversation

t-hiroishi
Copy link
Contributor

Ref #12670

  • Custom Error objects are correctly received by the renderer process when thrown from the main process.
  • Thrown Error objects from remote have information about the process that it was thrown.

@t-hiroishi t-hiroishi requested a review from a team April 24, 2018 08:08
@welcome
Copy link

welcome bot commented Apr 24, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound MarshallOfSound added the semver/minor backwards-compatible functionality label Apr 24, 2018
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks for this!

@codebytere codebytere merged commit 9c65abd into electron:master Apr 24, 2018
@welcome
Copy link

welcome bot commented Apr 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@t-hiroishi t-hiroishi deleted the remote-exception branch May 7, 2018 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants