New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle remote exception #12694

Merged
merged 4 commits into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@t-hiroishi
Contributor

t-hiroishi commented Apr 24, 2018

Ref #12670

  • Custom Error objects are correctly received by the renderer process when thrown from the main process.
  • Thrown Error objects from remote have information about the process that it was thrown.

t-hiroishi added some commits Apr 23, 2018

update exceptionToMeta function
* add sender argument
* and cause property to return value
update exception convert in metaToValue function
* add from and cause properties to the exception error

@t-hiroishi t-hiroishi requested a review from electron/reviewers as a code owner Apr 24, 2018

@welcome

This comment has been minimized.

welcome bot commented Apr 24, 2018

💖 Thanks for opening this pull request! 💖

typing cat

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
@codebytere

this is awesome, thanks for this!

@codebytere codebytere merged commit 9c65abd into electron:master Apr 24, 2018

10 checks passed

WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@welcome

This comment has been minimized.

welcome bot commented Apr 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@t-hiroishi t-hiroishi deleted the t-hiroishi:remote-exception branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment