fix: can't load module error when app is packaged

[jack-teng1]

Due to change in node.js(nodejs/node#17076) internalModuleReadFile has been renamed to internalModuleReadJSON, and in vendor/node/lib/internal/modules/cjs/loader.js it will call internalModuleReadJSON and result in can't read the package.json file.

Fixes #13185.

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix, OR prefix at least one of your commit messages.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[MarshallOfSound]

@jack-teng1 The tests are failing with internalModuleReadFile is not a function. We currently have a spec for internalModuleReadFile that indicates if it is working, it appears to still be functioning. Can you validate that the method you are trying to wrap actually exists?

[jack-teng1]

@MarshallOfSound I updated the spec to reflect the change in node.js. internalModuleReadFile is now renamed to internalModuleReadJSON

[alexeykuzmin]

@jack-teng1 Can you please rebase your branch onto electron:master?, and set master as a target branch?
upgrade-to-chromium-66 has been rebased and merged into it.

Just in case you need some help with Git =)

git checkout fix-asar-pack-cant-find-module
git fetch upstream # <- electron/electron remote
git rebase --onto upstream/master @~2 fix-asar-pack-cant-find-module
git push --force origin fix-asar-pack-cant-find-module  # <- jack-teng1/electron remote

[jack-teng1]

Thank you @alexeykuzmin, I have rebase the branch on to master

[jkleinsc]

Looks good to me. Thanks for the PR @jack-teng1!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[alexeykuzmin]

@jack-teng1 Thank you!