New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve --enable-features/--disable-features handling (2.0.x) #13921

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@poiru
Member

poiru commented Aug 2, 2018

As it turns out, we can reinitialize the feature list directly after the
user JS script has been executed instead of much later. This allows
modifications to --enable-features/--disable-features to work with a
greater set of features.

This backports #13920 to 2-0-x.

fix: Improve --enable-features/--disable-features handling (2.0.x)
As it turns out, we can reinitialize the feature list directly after the
user JS script has been executed instead of much later. This allows
modifications to `--enable-features`/`--disable-features` to work with a
greater set of features.

This backports #13920 to `2-0-x`.

@poiru poiru requested a review from electron/reviewers as a code owner Aug 2, 2018

@MarshallOfSound

This comment has been minimized.

Show comment
Hide comment
@MarshallOfSound

MarshallOfSound Aug 3, 2018

Member

@poiru We normally let the bot do the backporting so that this goes to all appropriate release lines. Gonna close this out but will re-visit if the bot fails to backport your master PR

Member

MarshallOfSound commented Aug 3, 2018

@poiru We normally let the bot do the backporting so that this goes to all appropriate release lines. Gonna close this out but will re-visit if the bot fails to backport your master PR

@MarshallOfSound MarshallOfSound merged commit dffd17a into 2-0-x Aug 3, 2018

12 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@MarshallOfSound MarshallOfSound deleted the reinit-feature-list-sooner-2-0-x branch Aug 3, 2018

@daviwil daviwil referenced this pull request Aug 9, 2018

Merged

:arrow_up: electron@2.0.7 #17815

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment