refactor: implement ipcRenderer.sendTo in native code for better performance #14285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ipcRenderer.sendTo
currently sends an internalELECTRON_BROWSER_SEND_TO
message, which is handled byrpc-server.js
. This leads to unnecessary native <-> V8 value conversions as the message is forwarded to the target renderer. This PR moves the forwarding to the native code to avoid this overhead.Tested by sending an IPC with 10 MB buffer to a different renderer and then back + measuring the time it takes for the message to come back:
Checklist
npm test
passesRelease Notes
Notes: ipcRenderer.sendTo performance improved by implementing forwarding in native code