-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initialize tracing controller before starting platform (3-0-x) #14503
Conversation
7c49751
to
2e5fca6
Compare
Please ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but before merge we should probably understand what the other things are that node does when initializing the tracing system: https://github.com/electron/node/blob/electron-node-v10.2.0-3.0.x/src/node.cc#L294-L297
@nornagon any idea who could do that? |
@alexeykuzmin i merged the Node PR, once you roll deps this can be merged! |
2e5fca6
to
bf67022
Compare
@codebytere |
Merging after discussion with @alexeykuzmin. If there are other node issues as mentioned above by @nornagon, they don't block this PR and can go in a followup. |
Release Notes Persisted
|
Description of Change
Fixes a crash when electron/node@19d1193 is reverted.
A PR to revert it is already created: electron/node#60
Checklist
npm test
passesRelease Notes
Notes: no notes