New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix window close (backport: 4-0-x) #15337

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@trop
Contributor

trop bot commented Oct 23, 2018

Backport of #15327

See that PR for details.

Notes: Fixed potential crash when closing windows on macOS 10.10 and10.11

@trop trop bot requested a review from electron/reviewers as a code owner Oct 23, 2018

@trop trop bot referenced this pull request Oct 23, 2018

Merged

fix: Fix window close #15327

0 of 5 tasks complete

@trop trop bot added 4-0-x backport labels Oct 23, 2018

@ckerr

ckerr approved these changes Oct 23, 2018

@codebytere codebytere merged commit 3a4c20b into electron:4-0-x Oct 23, 2018

19 of 20 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 23, 2018

Release Notes Persisted

Fixed potential crash when closing windows on macOS 10.10 and10.11

@ckerr ckerr referenced this pull request Oct 24, 2018

Merged

better release notes #15169

23 of 26 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment