New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor dialog.showMessageBox()'s Icon argument on Linux (backport: 4-0-x) #15343

Merged
merged 3 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Oct 23, 2018

Backport of #15326

See that PR for details.

Notes: Honor dialog.showMessageBox()'s icon argument on Linux

ckerr added some commits Oct 22, 2018

Don't call gtk_widget_show_all() on popup dialog.
Fixes #15317.

Notes: Fixed incorrect display of some GtkMessageDialog icons.

The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.

This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 23, 2018

@trop trop bot referenced this pull request Oct 23, 2018

Merged

fix: honor dialog.showMessageBox()'s Icon argument on Linux #15326

4 of 6 tasks complete

@trop trop bot added 4-0-x backport labels Oct 23, 2018

@codebytere codebytere merged commit a51ad1f into electron:4-0-x Oct 23, 2018

16 of 18 checks passed

ci/circleci: mas-testing CircleCI is running your tests
Details
ci/circleci: osx-testing CircleCI is running your tests
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 23, 2018

Release Notes Persisted

Honor dialog.showMessageBox()'s icon argument on Linux

@ckerr ckerr referenced this pull request Oct 24, 2018

Merged

better release notes #15169

23 of 26 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment