fix: honor dialog.showMessageBox()'s Icon argument on Linux (backport: 4-0-x) #15343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Fixes electron#15317. Notes: Fixed incorrect display of some GtkMessageDialog icons. The issue is caused because GtkMessageDialog contains an icon widget which is not shown when there's no associated icon. Our call to `gtk_widget_show_all()` overrides this, showing the uninitialized icon widget. This PR fixes the issue by calling `gtk_widget_show()` where needed and removing use of `gtk_widget_show_all()` in the message dialog.
6 tasks
codebytere
approved these changes
Oct 23, 2018
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15326
See that PR for details.
Notes: Honor dialog.showMessageBox()'s
iconargument on Linux