feat: add methods to allow customization of save dialog during will-download event #15497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/api/download-item.md
Outdated
|
|
||
| #### `downloadItem.getSaveDialogOptions()` | ||
|
|
||
| Returns `Object` - Returns the object previously set by `downloadItem.setSaveDialogOptions(options)`. |
There was a problem hiding this comment.
Does this return the defaults if they haven't been previously set?
There was a problem hiding this comment.
The defaults are only set after the JS callback actually runs AFAIK, so nope.
brenca
force-pushed
the
brenca/download-custom-title
branch
from
8e28c11 to
ab3fc3f
Compare
brenca
force-pushed
the
brenca/download-custom-title
branch
from
12c5291 to
652afe6
Compare
|
@MarshallOfSound done! |
docs/api/download-item.md
Outdated
| @@ -88,6 +88,19 @@ Returns `String` - The save path of the download item. This will be either the p | |||
| set via `downloadItem.setSavePath(path)` or the path selected from the shown | |||
| save dialog. | |||
|
|
|||
| #### `downloadItem.setSaveDialogOptions(options)` | |||
|
|
|||
| * `options` Object - Set the save file dialog options. This object has the same | |||
There was a problem hiding this comment.
This can be more specific, it isn't Object rather SaveDialogOptions
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This implements the request made in #15021. You can set the dialog options during the request, and those override the default values (we set the
window,titleanddefaultPathoptions by default).Checklist
npm testpassesRelease Notes
Notes: added methods to
DownloadItemthat enable customization of the save dialog options duringwill-downloadevents