Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hiddenInset titleBar console spam #15576

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Nov 5, 2018

Description of Change

Set [window setTitlebarAppearsTransparent:YES]; for hiddenInset. Should fix some of the remaining console spam users see:

2018-10-02 12:06:59.730 Electron[34332:825632] *** WARNING: Textured window <AtomNSWindow: 0x7fa08cd74cb0> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fix: hiddenInset titleBar console spam

@codebytere codebytere requested a review from as a code owner Nov 5, 2018

@codebytere codebytere changed the title fix: hiddenInset titleBar console spam fix: hiddenInset titleBar console spam Nov 6, 2018

@codebytere codebytere changed the title fix: hiddenInset titleBar console spam fix: hiddenInset titleBar console spam Nov 6, 2018

@codebytere codebytere merged commit ece4c81 into master Nov 6, 2018

27 checks passed

Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181105.15 succeeded
Details
electron-arm64-testing Build #20181105.15 succeeded
Details
electron-lint Build #20181105.19 succeeded
Details
electron-mas-testing Build #20181105.23 succeeded
Details
electron-osx-testing Build #20181105.24 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 6, 2018

Release Notes Persisted

fix: hiddenInset titleBar console spam

@codebytere codebytere deleted the fix-window-error branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.