Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make feature strings more robust to whitespace #15602

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@nornagon
Copy link
Contributor

commented Nov 6, 2018

Fixes #15594

The algorithm was already slightly lenient about whitespace, but surprisingly so. This makes it ignore all whitespace around , and = (and at beginning/end of the feature string).

Checklist

Release Notes

Notes: be more lenient about whitespace in webview's "webpreferences" feature string

@nornagon nornagon requested a review from MarshallOfSound Nov 6, 2018

@nornagon nornagon requested a review from as a code owner Nov 6, 2018

@nornagon nornagon requested a review from zcbenz Nov 6, 2018

@nornagon nornagon merged commit 10969b8 into master Nov 6, 2018

27 checks passed

Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181106.18 succeeded
Details
electron-arm64-testing Build #20181106.21 succeeded
Details
electron-lint Build #20181106.23 succeeded
Details
electron-mas-testing Build #20181106.23 succeeded
Details
electron-osx-testing Build #20181106.24 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 6, 2018

Release Notes Persisted

be more lenient about whitespace in webview's "webpreferences" feature string

@nornagon nornagon deleted the robust-parse-features-string branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.