Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add about panel customization on linux #15658

Merged
merged 1 commit into from
Nov 13, 2018
Merged

feat: add about panel customization on linux #15658

merged 1 commit into from
Nov 13, 2018

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 9, 2018 •
edited
Loading

Description of Change

Refs: #15591.

Adds an about panel on Linux with options to customize via setAboutPanelOptions.

/cc @ckerr @sindresorhus

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: add about panel customization on linux

@codebytere codebytere requested review from a team November 9, 2018 19:15
@sindresorhus
Copy link
Contributor

Would be nice to support gtk_about_dialog_set_comments() which is usually a short description of the app, and could default to the description property from package.json if it exists.

@sindresorhus
Copy link
Contributor

sindresorhus commented Nov 11, 2018 •
edited
Loading

I have also noticed that many Ubuntu apps have a website link in their About panel (gtk_about_dialog_set_website()), so would be nice to support a website option.

This could actually be supported on macOS too, by using an NSAttributedString with link style and action in the NSApplication.AboutPanelOptionKey.credits option, and combining it with the string from the user-supplied credits option.

sindresorhus
sindresorhus suggested changes Nov 11, 2018
View reviewed changes
docs/api/app.md Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the about-panel-linux branch 2 times, most recently from 6ec2ed9 to 10b160c Compare November 12, 2018 17:55
@codebytere codebytere changed the title [WIP] feat: add about panel customization on linux feat: add about panel customization on linux Nov 12, 2018
ckerr
ckerr approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many suggestions, no blockers :D

atom/browser/browser_linux.cc Outdated Show resolved Hide resolved
atom/browser/browser_linux.cc Outdated Show resolved Hide resolved
atom/browser/browser_linux.cc Show resolved Hide resolved
atom/browser/browser_linux.cc Outdated Show resolved Hide resolved
atom/browser/browser_linux.cc Outdated Show resolved Hide resolved
atom/browser/browser_linux.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the about-panel-linux branch 2 times, most recently from 81cd5d9 to 2a75c19 Compare November 13, 2018 19:28
@codebytere codebytere merged commit 787dbbe into master Nov 13, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 13, 2018

Release Notes Persisted

add about panel customization on linux

@ckerr ckerr deleted the about-panel-linux branch November 13, 2018 22:12
neo291 pushed a commit to neo291/electron that referenced this pull request Nov 16, 2018
@codebytere @neo291
feat: add about panel customization on linux (electron#15658)
affffd5
neo291 pushed a commit to neo291/electron that referenced this pull request Nov 16, 2018
@codebytere @neo291
feat: add about panel customization on linux (electron#15658)
945b443
@codebytere codebytere mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @sindresorhus @ckerr