Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add about panel customization on linux #15658

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Nov 9, 2018

Description of Change

Refs: #15591.

Adds an about panel on Linux with options to customize via setAboutPanelOptions.

/cc @ckerr @sindresorhus

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: add about panel customization on linux

@codebytere codebytere requested review from as code owners Nov 9, 2018

@sindresorhus

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2018

Would be nice to support gtk_about_dialog_set_comments() which is usually a short description of the app, and could default to the description property from package.json if it exists.

@sindresorhus

This comment has been minimized.

Copy link
Contributor

commented Nov 11, 2018

I have also noticed that many Ubuntu apps have a website link in their About panel (gtk_about_dialog_set_website()), so would be nice to support a website option.

This could actually be supported on macOS too, by using an NSAttributedString with link style and action in the NSApplication.AboutPanelOptionKey.credits option, and combining it with the string from the user-supplied credits option.

Show resolved Hide resolved docs/api/app.md Outdated

@codebytere codebytere force-pushed the about-panel-linux branch 2 times, most recently from 6ec2ed9 to 10b160c Nov 12, 2018

@codebytere codebytere changed the title [WIP] feat: add about panel customization on linux feat: add about panel customization on linux Nov 12, 2018

@ckerr

ckerr approved these changes Nov 13, 2018

Copy link
Member

left a comment

Many suggestions, no blockers :D

Show resolved Hide resolved atom/browser/browser_linux.cc Outdated
Show resolved Hide resolved atom/browser/browser_linux.cc Outdated
Show resolved Hide resolved atom/browser/browser_linux.cc
Show resolved Hide resolved atom/browser/browser_linux.cc Outdated
Show resolved Hide resolved atom/browser/browser_linux.cc Outdated
Show resolved Hide resolved atom/browser/browser_linux.cc Outdated

@codebytere codebytere force-pushed the about-panel-linux branch 2 times, most recently from 81cd5d9 to 2a75c19 Nov 13, 2018

@codebytere codebytere force-pushed the about-panel-linux branch from 77ee9db to 48517e7 Nov 13, 2018

@ckerr

ckerr approved these changes Nov 13, 2018

@codebytere codebytere merged commit 787dbbe into master Nov 13, 2018

22 of 26 checks passed

ci/circleci: linux-x64-testing Your tests failed on CircleCI
Details
electron-mas-testing Build #20181113.23 has failed
Details
electron-osx-testing Build #20181113.24 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181113.11 succeeded
Details
electron-arm64-testing Build #20181113.11 succeeded
Details
electron-lint Build #20181113.17 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 13, 2018

Release Notes Persisted

add about panel customization on linux

@ckerr ckerr deleted the about-panel-linux branch Nov 13, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.