Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn when nodeIntegration's default is relied on #16004

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Dec 10, 2018

Description of Change

nodeIntegration will be disabled by default in Electron 5.0. This adds a warning for users of 4.0 to help prepare for the change.

Checklist

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Release Notes

Notes: in Electron 5.0, the default for nodeIntegration will change from true to false. Electron 4 will log a warning in the renderer when nodeIntegration is enabled by default.

@nornagon nornagon requested review from ckerr, codebytere and a team December 10, 2018 22:07
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the code and it works perfectly.

@zcbenz zcbenz merged commit 913a433 into 4-0-x Dec 11, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 11, 2018

Release Notes Persisted

in Electron 5.0, the default for nodeIntegration will change from true to false. Electron 4 will log a warning in the renderer when nodeIntegration is enabled by default.

@zcbenz zcbenz deleted the nodeintegration-default-warning branch December 11, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants