fix: do not allow the window to grab focus when tabbing / shift+tabbing

[ppontes]

Description of Change

Keep the focus restrained to the set of focusable elements when the user tabs or SHIFT + tabs through the focusable elements in a page. Do not allow it to move to the browser window as it is unexpected in a desktop app and no visual indication is given that the browser window is focused.

Fixes #12919.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines

Release Notes

Notes: Fixed a problem where the focus would move to the browser window after the user (SHIFT +) tabbed through all the elements in the page (#12919).

[bpasero]

Very cool, looking forward to have this in VSCode 👍

[deepak1556]

LGTM, can you also add a test with <webview> just to confirm there aren't any regressions. Thanks!

In this change, the tab traversal is made effective only if its the outer most webContents which isn't the case for <webview>, but just to be sure.

[ppontes]

@deepak1556 Thanks for the review and great suggestion to include a webview in the tests, I had tested it manually but we should ensure it doesn't regress. It has been included in the tests..

[deepak1556]

Nice 👍

[release-clerk]

Release Notes Persisted

Fixed a problem where the focus would move to the browser window after the user (SHIFT +) tabbed through all the elements in the page (#12919).