New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: beep on Ubuntu (backport: 4-0-x) #16357

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Jan 10, 2019

Backport of #16350

See that PR for details.

Notes: Fixed shell.beep() on Ubuntu.

fix: beep on Ubuntu
beeps on Linux are made by writing BEL to /dev/console,
which requires elevated permissions on Ubuntu. So if
opening /dev/console fails, fall back to /dev/tty.

@trop trop bot requested a review from electron/reviewers as a code owner Jan 10, 2019

@trop trop bot referenced this pull request Jan 10, 2019

Merged

fix: beep on Ubuntu #16350

4 of 4 tasks complete

@trop trop bot added 4-0-x backport labels Jan 10, 2019

@codebytere codebytere merged commit e05e181 into electron:4-0-x Jan 11, 2019

18 of 20 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment