ci: build mac on CircleCI #16552
Merged
ci: build mac on CircleCI #16552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 30, 2019
jkleinsc
force-pushed
the
move-mac-to-circle
branch
from
dddac33 to
5cff8c8
Compare
jkleinsc
force-pushed
the
move-mac-to-circle
branch
from
5cff8c8 to
061ebd8
Compare
|
No Release Notes |
4 tasks
|
A maintainer has manually backported this PR to "5-0-x", please check out #16656 |
|
A maintainer has manually backported this PR to "5-0-x", please check out #16656 |
4 tasks
4 tasks
|
A maintainer has manually backported this PR to "4-0-x", please check out #16933 |
1 similar comment
|
A maintainer has manually backported this PR to "4-0-x", please check out #16933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR moves our Mac CI from VSTS over to CircleCI. Also, it disables the app.get/setLoginItemSettings API tests for MAS builds because they are consistently flaky there.
Checklist
npm testpassesRelease Notes
Notes: no-notes