Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execute session preload scripts in sandboxed renderers (backport: 5-0-x) #16578

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Jan 29, 2019

Backport of #16538

See that PR for details.

Notes: Fixed session preload scripts not being executed in sandboxed renderers.

@trop trop bot requested a review from as a code owner Jan 29, 2019

@trop trop bot referenced this pull request Jan 29, 2019

Merged

fix: execute session preload scripts in sandboxed renderers #16538

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Jan 29, 2019

@codebytere codebytere merged commit 6dcf5c5 into electron:5-0-x Jan 30, 2019

20 of 22 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 30, 2019

Release Notes Persisted

Fixed session preload scripts not being executed in sandboxed renderers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.