Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add removeInsertedCSS #16579

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@brenca
Copy link
Member

brenca commented Jan 29, 2019

Description of Change

Fixes #16475.
This PR adds a pair for insertCSS, that kinda works like setTimeout and clearTimeout - insertCSS has a return value that we didn't use before, that is a unique key for the inserted CSS. Using that, we can remove the inserted CSS.

Depends on #18792

Checklist

Release Notes

Notes: Added removeInsertedCSS() to webFrame / webContents / <webview>.

@brenca brenca requested review from and MarshallOfSound Jan 29, 2019
@brenca brenca force-pushed the brenca/remove-css branch from 938e2b1 to 39ded24 Jan 30, 2019
Copy link
Contributor

jkleinsc left a comment

Overall looks good to me - just a small nit on the docs.

Also, can you rebase the latest from master onto this PR? It should resolve the failing CI.

docs/api/web-contents.md Outdated Show resolved Hide resolved
@brenca brenca force-pushed the brenca/remove-css branch from 649945f to 09b7a62 Feb 4, 2019
@brenca

This comment has been minimized.

Copy link
Member Author

brenca commented Feb 5, 2019

@jkleinsc The one remaining failure seems unrelated, ready for review again!

@brenca brenca force-pushed the brenca/remove-css branch from 09b7a62 to 70c03d3 Feb 8, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 11, 2019

@brenca CI is green. Just need to rebase and we can merge this one.

@brenca brenca force-pushed the brenca/remove-css branch from 70c03d3 to b46cc98 Feb 12, 2019
@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Feb 26, 2019

@brenca This PR is in conflict, could you rebase and fix lint so we can look at merging this 👍

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented Mar 27, 2019

@brenca, is this PR still active? It hasn't been touched in a month; however, last time it had activity it looks like all it needed was a rebase/delint before it could land

@brenca brenca force-pushed the brenca/remove-css branch from b46cc98 to fca3c8b Apr 25, 2019
filenames.auto.gni Outdated Show resolved Hide resolved
docs/api/web-contents.md Outdated Show resolved Hide resolved
@miniak

This comment has been minimized.

Copy link
Contributor

miniak commented May 1, 2019

@brenca please rebase

@miniak miniak force-pushed the brenca/remove-css branch from fca3c8b to d27ba90 Jun 14, 2019
@miniak
miniak approved these changes Jun 14, 2019
@miniak

This comment has been minimized.

Copy link
Contributor

miniak commented Jun 14, 2019

@ckerr I've rebased and fixed the PR. I've separated a prerequisite change to #18792 (1st commit in this PR), which should be merged fist.

@miniak miniak force-pushed the brenca/remove-css branch 5 times, most recently from 51b4424 to 3caad7c Jun 14, 2019
@miniak miniak force-pushed the brenca/remove-css branch 2 times, most recently from 9a61ba2 to f1a134c Jun 17, 2019
spec/webview-spec.js Outdated Show resolved Hide resolved
spec/webview-spec.js Outdated Show resolved Hide resolved
@miniak miniak force-pushed the brenca/remove-css branch from f1a134c to 5297212 Jun 17, 2019
@miniak miniak force-pushed the brenca/remove-css branch from 5297212 to aef0456 Jun 17, 2019
@miniak miniak requested a review from alexeykuzmin Jun 17, 2019
@miniak miniak self-assigned this Jun 17, 2019
@jkleinsc jkleinsc merged commit 5a08522 into master Jun 17, 2019
12 of 13 checks passed
12 of 13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190617.18 had test failures
Details
electron-arm64-testing Build #20190617.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@jkleinsc jkleinsc deleted the brenca/remove-css branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.