-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add removeInsertedCSS #16579
feat: add removeInsertedCSS #16579
Conversation
938e2b1
to
39ded24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me - just a small nit on the docs.
Also, can you rebase the latest from master onto this PR? It should resolve the failing CI.
649945f
to
09b7a62
Compare
@jkleinsc The one remaining failure seems unrelated, ready for review again! |
09b7a62
to
70c03d3
Compare
@brenca CI is green. Just need to rebase and we can merge this one. |
70c03d3
to
b46cc98
Compare
@brenca This PR is in conflict, could you rebase and fix lint so we can look at merging this 👍 |
@brenca, is this PR still active? It hasn't been touched in a month; however, last time it had activity it looks like all it needed was a rebase/delint before it could land |
b46cc98
to
fca3c8b
Compare
@brenca please rebase |
fca3c8b
to
d27ba90
Compare
51b4424
to
3caad7c
Compare
9a61ba2
to
f1a134c
Compare
f1a134c
to
5297212
Compare
5297212
to
aef0456
Compare
Description of Change
Fixes #16475.
This PR adds a pair for
insertCSS
, that kinda works likesetTimeout
andclearTimeout
-insertCSS
has a return value that we didn't use before, that is a unique key for the inserted CSS. Using that, we can remove the inserted CSS.Depends on #18792
Checklist
npm test
passesRelease Notes
Notes: Added
removeInsertedCSS()
towebFrame
/webContents
/<webview>
.