Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add removeInsertedCSS #16579

Merged
merged 1 commit into from
Jun 17, 2019
Merged

feat: add removeInsertedCSS #16579

merged 1 commit into from
Jun 17, 2019

Conversation

brenca
Copy link
Contributor

@brenca brenca commented Jan 29, 2019

Description of Change

Fixes #16475.
This PR adds a pair for insertCSS, that kinda works like setTimeout and clearTimeout - insertCSS has a return value that we didn't use before, that is a unique key for the inserted CSS. Using that, we can remove the inserted CSS.

Depends on #18792

Checklist

Release Notes

Notes: Added removeInsertedCSS() to webFrame / webContents / <webview>.

@brenca brenca requested review from a team and MarshallOfSound January 29, 2019 01:24
@brenca brenca force-pushed the brenca/remove-css branch from 938e2b1 to 39ded24 Compare January 30, 2019 16:29
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me - just a small nit on the docs.

Also, can you rebase the latest from master onto this PR? It should resolve the failing CI.

docs/api/web-contents.md Outdated Show resolved Hide resolved
@brenca brenca force-pushed the brenca/remove-css branch from 649945f to 09b7a62 Compare February 4, 2019 21:46
@brenca
Copy link
Contributor Author

brenca commented Feb 5, 2019

@jkleinsc The one remaining failure seems unrelated, ready for review again!

@brenca brenca force-pushed the brenca/remove-css branch from 09b7a62 to 70c03d3 Compare February 8, 2019 02:24
@jkleinsc
Copy link
Member

@brenca CI is green. Just need to rebase and we can merge this one.

@MarshallOfSound
Copy link
Member

@brenca This PR is in conflict, could you rebase and fix lint so we can look at merging this 👍

@ckerr
Copy link
Member

ckerr commented Mar 27, 2019

@brenca, is this PR still active? It hasn't been touched in a month; however, last time it had activity it looks like all it needed was a rebase/delint before it could land

@brenca brenca force-pushed the brenca/remove-css branch from b46cc98 to fca3c8b Compare April 25, 2019 15:18
filenames.auto.gni Outdated Show resolved Hide resolved
docs/api/web-contents.md Outdated Show resolved Hide resolved
@miniak
Copy link
Contributor

miniak commented May 1, 2019

@brenca please rebase

@miniak miniak force-pushed the brenca/remove-css branch from fca3c8b to d27ba90 Compare June 14, 2019 08:54
@miniak
Copy link
Contributor

miniak commented Jun 14, 2019

@ckerr I've rebased and fixed the PR. I've separated a prerequisite change to #18792 (1st commit in this PR), which should be merged fist.

@miniak miniak force-pushed the brenca/remove-css branch 5 times, most recently from 51b4424 to 3caad7c Compare June 14, 2019 09:51
@miniak miniak force-pushed the brenca/remove-css branch 2 times, most recently from 9a61ba2 to f1a134c Compare June 17, 2019 09:33
spec/webview-spec.js Outdated Show resolved Hide resolved
spec/webview-spec.js Outdated Show resolved Hide resolved
@miniak miniak force-pushed the brenca/remove-css branch from f1a134c to 5297212 Compare June 17, 2019 12:06
@miniak miniak force-pushed the brenca/remove-css branch from 5297212 to aef0456 Compare June 17, 2019 12:09
@miniak miniak requested a review from alexeykuzmin June 17, 2019 12:09
@miniak miniak self-assigned this Jun 17, 2019
@jkleinsc jkleinsc merged commit 5a08522 into master Jun 17, 2019
@jkleinsc jkleinsc deleted the brenca/remove-css branch June 17, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove injected stylesheets
7 participants