Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move open handling to web-contents.js #16630

Merged
merged 2 commits into from
Jan 31, 2019
Merged

fix: move open handling to web-contents.js #16630

merged 2 commits into from
Jan 31, 2019

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jan 30, 2019 •
edited by codebytere
Loading

Description of Change

Move window.open() handling from browser-window.js to web-contents.js

Related: 3-1-x, 4-0-x and master

CC @alexeykuzmin @BinaryMuse @codebytere @MarshallOfSound

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@ckerr ckerr requested a review from a team January 30, 2019 21:33
@codebytere codebytere added 3-0-x 2-0-x backport This is a backport PR and removed 3-0-x labels Jan 30, 2019
@codebytere codebytere merged commit 0309654 into 2-0-x Jan 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2019

No Release Notes

@codebytere codebytere deleted the browserView-open_2-0-x branch January 31, 2019 03:49
@nornagon
Copy link
Member

nornagon commented Feb 6, 2019

the 'master' link here seems to link to the wrong PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
2-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @nornagon @codebytere