Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new components to Display structure #16870

Merged
merged 4 commits into from Feb 12, 2019

Conversation

@codebytere
Copy link
Member

commented Feb 11, 2019

Description of Change

Resolves #16078.

In the years since we added the Display API structure, Chromium has added several new fields (and accessors for the them) to it: monochrome, accelerometerEnabled, internal, and depthPerComponent. This PR thus adds these three new fields to our own Display structure.

cc @ckerr @MarshallOfSound @deepak1556

Checklist

Release Notes

Notes: Added new monochrome, internal, acceleratorEnabled, colorDepth and depthPerComponent properties to the Display API Structure.

@codebytere codebytere requested review from as code owners Feb 11, 2019

@codebytere codebytere changed the title feat: add new components to Display structure [wip] feat: add new components to Display structure Feb 11, 2019

@codebytere codebytere force-pushed the add-display-monochrome branch from f4972c9 to 032d5b7 Feb 11, 2019

@codebytere codebytere changed the title [wip] feat: add new components to Display structure feat: add new components to Display structure Feb 11, 2019

@jkleinsc
Copy link
Contributor

left a comment

LGTM

@miniak

miniak approved these changes Feb 11, 2019

@miniak

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Also color_space() can be useful, to detect whether the display is HDR or wide gamut. This one can be done in a separate PR as we need to figure out how to represent the color space, maybe another struct with several properties.

@miniak
Copy link
Contributor

left a comment

can you expose color_depth() as well?

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

@miniak updated: i'll expose color_space in a follow-up PR.

@miniak

miniak approved these changes Feb 11, 2019

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

a test would be great!

@jkleinsc jkleinsc merged commit bf276ec into master Feb 12, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190212.8 succeeded
Details
electron-arm64-testing Build #20190212.8 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 12, 2019

Release Notes Persisted

Added new monochrome, internal, acceleratorEnabled, colorDepth and depthPerComponent properties to the Display API Structure.

@jkleinsc jkleinsc deleted the add-display-monochrome branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.