-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new components to Display structure #16870
Conversation
f4972c9
to
032d5b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you expose color_depth()
as well?
@miniak updated: i'll expose color_space in a follow-up PR. |
a test would be great! |
Release Notes Persisted
|
Description of Change
Resolves #16078.
In the years since we added the
Display
API structure, Chromium has added several new fields (and accessors for the them) to it:monochrome
,accelerometerEnabled
,internal
, anddepthPerComponent
. This PR thus adds these three new fields to our own Display structure.cc @ckerr @MarshallOfSound @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Added new
monochrome
,internal
,acceleratorEnabled
,colorDepth
anddepthPerComponent
properties to the Display API Structure.