Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new components to Display structure #16870

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 11, 2019

Description of Change

Resolves #16078.

In the years since we added the Display API structure, Chromium has added several new fields (and accessors for the them) to it: monochrome, accelerometerEnabled, internal, and depthPerComponent. This PR thus adds these three new fields to our own Display structure.

cc @ckerr @MarshallOfSound @deepak1556

Checklist

Release Notes

Notes: Added new monochrome, internal, acceleratorEnabled, colorDepth and depthPerComponent properties to the Display API Structure.

@codebytere codebytere requested review from a team February 11, 2019 15:50
@codebytere codebytere changed the title feat: add new components to Display structure [wip] feat: add new components to Display structure Feb 11, 2019
@codebytere codebytere force-pushed the add-display-monochrome branch from f4972c9 to 032d5b7 Compare February 11, 2019 16:20
@codebytere codebytere changed the title [wip] feat: add new components to Display structure feat: add new components to Display structure Feb 11, 2019
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere added semver/major incompatible API changes semver/minor backwards-compatible functionality and removed semver/major incompatible API changes labels Feb 11, 2019
@miniak
Copy link
Contributor

miniak commented Feb 11, 2019

Also color_space() can be useful, to detect whether the display is HDR or wide gamut. This one can be done in a separate PR as we need to figure out how to represent the color space, maybe another struct with several properties.

Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expose color_depth() as well?

@codebytere
Copy link
Member Author

@miniak updated: i'll expose color_space in a follow-up PR.

@nornagon
Copy link
Member

a test would be great!

@jkleinsc jkleinsc merged commit bf276ec into master Feb 12, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2019

Release Notes Persisted

Added new monochrome, internal, acceleratorEnabled, colorDepth and depthPerComponent properties to the Display API Structure.

@jkleinsc jkleinsc deleted the add-display-monochrome branch February 12, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants