Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new powerMonitor synchronous API #17144

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@nitsakh
Copy link
Contributor

commented Feb 26, 2019

powerMonitor.querySystemIdleState and powerMonitor.querySystemIdleTime had async backing APIs in chromium (https://chromium-review.googlesource.com/c/chromium/src/+/1379183). However, that has changed in ch73. So, this PR deprecates the old async APIs and adds new sync APIs.
Refer this comment.

Description of Change

Checklist

Release Notes

Notes: Replaced powerMonitor querySystemIdleState and querySystemIdleTime with synchronous APIs.

@nitsakh nitsakh requested review from as code owners Feb 26, 2019

feat: Add new powerMonitor synchronous API
`powerMonitor.querySystemIdleState` and `powerMonitor.querySystemIdleTime` had async backing APIs in chromium (https://chromium-review.googlesource.com/c/chromium/src/+/1379183). However, that has changed in ch73. So, this PR deprecates the old async APIs and adds new sync APIs.

@nitsakh nitsakh force-pushed the power-monitor-deprecation branch from 56a127c to a2f6475 Feb 26, 2019

@jkleinsc jkleinsc removed the new-pr 🌱 label Feb 27, 2019

@jkleinsc jkleinsc merged commit bfa07ec into master Feb 27, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190226.22 succeeded
Details
electron-arm64-testing Build #20190226.23 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 27, 2019

Release Notes Persisted

Replaced powerMonitor querySystemIdleState and querySystemIdleTime with synchronous APIs.

@jkleinsc jkleinsc deleted the power-monitor-deprecation branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.