feat: add safer nativeImage.createFromBitmap(), which does not decode PNG/JPEG

[miniak]

Description of Change

Required to safely serialize/deserialize NativeImage instances to be sent over IPC in #17200

/cc @nornagon

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added safer nativeImage.createFromBitmap(), which does not decode PNG/JPEG.

[nornagon]

IMO we should deprecate createFromBuffer, and replace it with createFromBitmap (or maybe createFromRGBA), createFromPNG and createFromJPEG. Just guessing at the image format isn't really a sane way to do it.

[miniak]

@nornagon I was just thinking about doing that. I agree that having separate createFromPNG and createFromJPEG is cleaner. I will do that in a follow up PR. What about addRepresentation? That one has the same issues.

[MarshallOfSound]

I'm thinking we should probably have some kind of "guess what this is" method. I can see it being handy when you think a file is an image but don't know what format it is.

[nornagon]

I think that falls outside the scope of Electron. See e.g. http://www.darwinsys.com/file/

[MarshallOfSound]

@nornagon At least pointing people to that / an npm module for file type detection would be enough. I just don't want to say "figure it out have fun" 👍

[sindresorhus]

Just guessing at the image format isn't really a sane way to do it.

It's not guessing, it's detecting, and I think it should stay. It's a nice convenience. I agree there should also be explicit methods for JPEG and PNG.

[sindresorhus]

At least pointing people to that / an npm module for file type detection would be enough. I just don't want to say "figure it out have fun" 👍

My file-type package is the most popular one.

[release-clerk]

Release Notes Persisted

Added safer nativeImage.createFromBitmap(), which does not decode PNG/JPEG.