Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make badgeCount a property on app #17363

Merged
merged 1 commit into from
Apr 25, 2019
Merged

feat: make badgeCount a property on app #17363

merged 1 commit into from
Apr 25, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 13, 2019 •
edited
Loading

Description of Change

This PR converts badgeCount to a proper JS property on app, so that users can use get and set on properties instead of using app.getBadgeCount() and app.setbadgeCount(count).

Checklist

Release Notes

Notes: Converted badgeCount to an actual property on the app module.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 13, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch from 764a335 to d17b665 Compare March 13, 2019 03:51
@codebytere codebytere force-pushed the app-badgecount-prop branch from d17b665 to 6cb008c Compare March 13, 2019 20:51
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 14, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch 5 times, most recently from d38954e to 347e504 Compare April 5, 2019 04:15
@codebytere codebytere marked this pull request as ready for review April 5, 2019 04:15
@codebytere codebytere force-pushed the app-badgecount-prop branch from 347e504 to 35f66f6 Compare April 5, 2019 04:21
@codebytere codebytere force-pushed the app-badgecount-prop branch 6 times, most recently from 92f1198 to fb8576d Compare April 25, 2019 20:50
@codebytere codebytere force-pushed the app-badgecount-prop branch from fb8576d to 788ca66 Compare April 25, 2019 21:08
@codebytere codebytere added the semver/minor backwards-compatible functionality label Apr 25, 2019
@codebytere codebytere changed the title refactor: make badgeCount a property on app feat: make badgeCount a property on app Apr 25, 2019
@codebytere codebytere merged commit 075b818 into master Apr 25, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 25, 2019

Release Notes Persisted

Converted badgeCount to an actual property on the app module.

@codebytere codebytere deleted the app-badgecount-prop branch April 25, 2019 22:45
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
fixes (electron#17363)
a6fd257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound