Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make badgeCount a property on app #17363

Merged
merged 1 commit into from Apr 25, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Mar 13, 2019

Description of Change

This PR converts badgeCount to a proper JS property on app, so that users can use get and set on properties instead of using app.getBadgeCount() and app.setbadgeCount(count).

Checklist

Release Notes

Notes: Converted badgeCount to an actual property on the app module.

@codebytere codebytere force-pushed the app-badgecount-prop branch from 764a335 to d17b665 Mar 13, 2019
lib/browser/api/app.ts Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the app-badgecount-prop branch from d17b665 to 6cb008c Mar 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 14, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch 5 times, most recently from d38954e to 347e504 Apr 5, 2019
@codebytere codebytere marked this pull request as ready for review Apr 5, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch from 347e504 to 35f66f6 Apr 5, 2019
@codebytere codebytere requested a review from MarshallOfSound Apr 19, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch 6 times, most recently from 92f1198 to fb8576d Apr 19, 2019
@codebytere codebytere force-pushed the app-badgecount-prop branch from fb8576d to 788ca66 Apr 25, 2019
@codebytere codebytere changed the title refactor: make badgeCount a property on app feat: make badgeCount a property on app Apr 25, 2019
@codebytere codebytere merged commit 075b818 into master Apr 25, 2019
14 of 15 checks passed
14 of 15 checks passed
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190425.20 succeeded
Details
electron-arm64-testing Build #20190425.20 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Apr 25, 2019

Release Notes Persisted

Converted badgeCount to an actual property on the app module.

@codebytere codebytere deleted the app-badgecount-prop branch Apr 25, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.