Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: add process.getBlinkMemoryInfo() #17762
Description of Change
Expose blink memory information provided by https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/heap/process_heap.h
Few questions before my plane takes off.
How does this line up with the existing process.getMemoryInfo API?
Can we / should we combine them?
How does the unified heap (shipped in 73 iirc) impact these APIs?
And then can we strongly document the answers to the above questions so when users look at these APIs they know what the values mean / represent
@MarshallOfSound actually that blink API I've used seems to be private. I am getting this error:
trying to add the dependency results in another error:
I assume the question is on
We should not combine them because these are used for debugging different issue. Blink memory info will be used mostly to debug rendering/dom related memory issues.
There should not be any difference in terms of what these api's return for blink gc allocations, before and after unified heap.
Sure, we should do this.