build: disable Vulkan support by default (4-1-x) #17789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is was enabled in https://chromium.googlesource.com/chromium/src.git/+/327326656f2c8c45ecb0ff4675e5c577e7c275ef which landed in 69.0.3460.0 Vulkan support would require a command line parameter "--enable-vulkan" to be passes to a binary to be enabled anyway, so this change doesn't actual alter the current behaviour of Electron. (cherry picked from commit e05e45d)
alexeykuzmin
changed the title
4 tasks
|
Suggest release notes change:
Since we don't actually support vulkan even when shipping these binaries (you mentioned it doesn't work even if you pass the flag), I wouldn't say we're disabling anything here? |
4 tasks
|
@nornagon You just could have updated the release notes yourself =) Done. |
jkleinsc
approved these changes
Apr 16, 2019
|
Release Notes Persisted
|
3 tasks
jkleinsc
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Is was enabled in
https://chromium.googlesource.com/chromium/src.git/+/327326656f2c8c45ecb0ff4675e5c577e7c275ef
which landed in 69.0.3460.0
Vulkan support would require a command line parameter "--enable-vulkan"
to be passes to a binary to be enabled anyway,
so this change doesn't actual alter the current behaviour of Electron.
Checklist
npm testpassesRelease Notes
Notes: Removed unused Vulkan libraries from bundle.