Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make templateImage a property on nativeImage #18124

Merged
merged 5 commits into from May 7, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented May 2, 2019

Description of Change

Update nativeImage.templateImage to be a property on the nativeImage prototype.

Checklist

Release Notes

Notes: Updates nativeImage.templateImage to be a property on the nativeImage prototype.

@codebytere codebytere requested review from nornagon and miniak May 2, 2019
docs/api/native-image.md Outdated Show resolved Hide resolved
docs/api/native-image.md Outdated Show resolved Hide resolved
spec/api-native-image-spec.js Show resolved Hide resolved
codebytere and others added 2 commits Apr 30, 2019
Co-Authored-By: codebytere <codebytere@github.com>
@codebytere codebytere force-pushed the template-image-property branch from 2ad4323 to dd3d54c May 3, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label May 3, 2019
@miniak
miniak approved these changes May 4, 2019
@codebytere codebytere requested a review from MarshallOfSound May 6, 2019
@codebytere codebytere requested a review from MarshallOfSound May 7, 2019
Co-Authored-By: codebytere <codebytere@github.com>
@jkleinsc jkleinsc merged commit 02710ef into master May 7, 2019
12 of 13 checks passed
12 of 13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190507.3 succeeded
Details
electron-arm64-testing Build #20190507.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented May 7, 2019

Release Notes Persisted

Updates nativeImage.templateImage to be a property on the nativeImage prototype.

@jkleinsc jkleinsc deleted the template-image-property branch May 7, 2019
Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019
* refactor: make templateImage a property on nativeImage

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>

* fix nativeImage prototype deprecation

* update for new property name

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.