Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make templateImage a property on nativeImage #18124

Merged
merged 5 commits into from
May 7, 2019
Merged

refactor: make templateImage a property on nativeImage #18124

merged 5 commits into from
May 7, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 2, 2019 •
edited
Loading

Description of Change

Update nativeImage.templateImage to be a property on the nativeImage prototype.

Checklist

Release Notes

Notes: Updates nativeImage.templateImage to be a property on the nativeImage prototype.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 2, 2019
@codebytere codebytere requested review from nornagon and miniak May 2, 2019 19:02
@codebytere codebytere added the semver/minor backwards-compatible functionality label May 2, 2019
MarshallOfSound
MarshallOfSound requested changes May 2, 2019
View reviewed changes
docs/api/native-image.md Outdated Show resolved Hide resolved
docs/api/native-image.md Outdated Show resolved Hide resolved
spec/api-native-image-spec.js Show resolved Hide resolved
codebytere and others added 2 commits May 3, 2019 08:45
@codebytere codebytere force-pushed the template-image-property branch from 2ad4323 to dd3d54c Compare May 3, 2019 16:53
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 3, 2019
@codebytere codebytere requested a review from MarshallOfSound May 6, 2019 15:23
@codebytere codebytere requested a review from MarshallOfSound May 7, 2019 03:16
@MarshallOfSound @codebytere
Update docs/api/native-image.md
2933677 
Co-Authored-By: codebytere <codebytere@github.com>
@jkleinsc jkleinsc merged commit 02710ef into master May 7, 2019
@release-clerk
Copy link

release-clerk bot commented May 7, 2019

Release Notes Persisted

Updates nativeImage.templateImage to be a property on the nativeImage prototype.

@jkleinsc jkleinsc deleted the template-image-property branch May 7, 2019 13:52
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
refactor: make templateImage a property on nativeImage (electron#18124)
163a0b4 
* refactor: make templateImage a property on nativeImage

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>

* fix nativeImage prototype deprecation

* update for new property name

* Update docs/api/native-image.md

Co-Authored-By: codebytere <codebytere@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@miniak miniak miniak approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @jkleinsc @miniak @MarshallOfSound