Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 924843: DCHECK failure in IsAligned(DistanceTo(target), kInstrSize) in #18545

merged 1 commit into from Jun 15, 2019


4 participants
Copy link

commented May 31, 2019

Description of Change

Backport fix for

[Liftoff] Correctly unuse Labels

On Liftoff bailout, instead of binding all unbound labels (to avoid
triggering DCHECKS in their destructor), just Unuse them.

/cc @electron/wg-security


Release Notes

Notes: Backported fix for

@miniak miniak added the 5-0-x label May 31, 2019

@miniak miniak requested a review from electron/wg-security May 31, 2019

@miniak miniak self-assigned this May 31, 2019

@miniak miniak force-pushed the miniak/liftoff-correctly-unuse-labels-5-0-x branch from d5607e9 to 20fabab Jun 5, 2019


zcbenz approved these changes Jun 15, 2019

@zcbenz zcbenz merged commit 183c687 into 5-0-x Jun 15, 2019

11 of 13 checks passed

Valid Backport Invalid Backport
electron-arm-testing Build #20190605.13 had test failures
Artifact Comparison No Changes
Semantic Pull Request ready to be squashed
WIP Ready for review
appveyor: win-ia32-testing AppVeyor build succeeded
appveyor: win-ia32-testing-pr AppVeyor build succeeded
appveyor: win-x64-testing AppVeyor build succeeded
appveyor: win-x64-testing-pr AppVeyor build succeeded
build-linux Workflow: build-linux
build-mac Workflow: build-mac
electron-arm64-testing Build #20190605.13 succeeded
release-notes Release notes found

This comment has been minimized.

Copy link

commented Jun 15, 2019

Release Notes Persisted

Backported fix for

@zcbenz zcbenz deleted the miniak/liftoff-correctly-unuse-labels-5-0-x branch Jun 15, 2019

@sofianguy sofianguy added this to Fixed in 5.0.5 in 5.0.x Jun 21, 2019


This comment has been minimized.

Copy link

commented Jun 26, 2019

Root my phone please thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.