Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SVG crash for v0 distribution into foreignObject #18561

Conversation

Projects
None yet
4 participants
@miniak
Copy link
Contributor

commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=915469
https://chromium.googlesource.com/chromium/src.git/+/032c3339bfb454c65ce38e7eafe49a54bac83073

Fix SVG crash for v0 distribution into foreignObject.

We require a parent element to be an SVG element for non-svg-root
elements in order to create a LayoutObject for them. However, we checked
the light tree parent element, not the flat tree one which is the parent
for the layout tree construction. Note that this is just an issue in
Shadow DOM v0 since v1 does not allow shadow roots on SVG elements.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=915469.

@miniak miniak requested a review from electron/wg-security Jun 1, 2019

@miniak miniak self-assigned this Jun 1, 2019

@miniak miniak added the 4-2-x label Jun 1, 2019

@miniak miniak changed the title fix: SVG crash for v0 distribution into foreignObject. fix: Issue 915469: Security: Type Confusion in LayoutBlockFlow::CreateLineBoxes Jun 1, 2019

@miniak miniak changed the title fix: Issue 915469: Security: Type Confusion in LayoutBlockFlow::CreateLineBoxes fix: Fix SVG crash for v0 distribution into foreignObject Jun 1, 2019

@zcbenz

zcbenz approved these changes Jun 2, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 2, 2019

@miniak miniak added the security 🔒 label Jun 3, 2019

@codebytere codebytere added the backport label Jun 3, 2019

@miniak miniak added backport and removed backport labels Jun 3, 2019

@zcbenz zcbenz merged commit 7d164b3 into 4-2-x Jun 4, 2019

12 of 13 checks passed

Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190604.21 succeeded
Details
electron-arm64-testing Build #20190604.21 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=915469.

@zcbenz zcbenz deleted the miniak/fix_svg_crash_for_v0_distribution_into_foreignobject-4-2-x branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.