Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract #18564

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913296
https://chromium.googlesource.com/v8/v8.git/+/e3c923962677908c183121644c945777cdb31570

[turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract.

The typing of SpeculativeSafeIntegerSubtract didn't include -0, and the
SimplifiedLowering rules for SpeculativeSafeIntegerSubtract didn't
properly handle the case of -0 - 0, but would always pass Word32
truncations.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913296.

@miniak miniak added the 4-2-x label Jun 1, 2019

@miniak miniak requested a review from electron/wg-security Jun 1, 2019

@miniak miniak self-assigned this Jun 1, 2019

@miniak miniak changed the title fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract. fix: Issue 913296: Security: V8: Incorrect type information on SpeculativeSafeIntegerSubtract Jun 1, 2019

@miniak miniak changed the title fix: Issue 913296: Security: V8: Incorrect type information on SpeculativeSafeIntegerSubtract fix: [turbofan] Fix wrong typing of SpeculativeSafeIntegerSubtract Jun 1, 2019

@zcbenz

zcbenz approved these changes Jun 2, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 2, 2019

@nornagon nornagon merged commit ec2418a into 4-2-x Jun 3, 2019

12 of 13 checks passed

Valid Backport Invalid Backport
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190601.13 succeeded
Details
electron-arm64-testing Build #20190601.14 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 3, 2019

Release Notes Persisted

Backported fix https://bugs.chromium.org/p/chromium/issues/detail?id=913296.

@nornagon nornagon deleted the miniak/backport-913296-4-2-x branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.