Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [turbofan] Restrict redundancy elimination from widening types #18569

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340
https://chromium.googlesource.com/v8/v8.git/+/5a9fa8f304c2a627af21d7b35488be8f4bf24b47

[turbofan] Restrict redundancy elimination from widening types

This CL prevents redundancy elimination from widening types, which
can cause problems if the input of a DeadValue (which has type None)
is replaced by an equivalent node that does not have type None. This
can happen because load elimination does not re-type nodes, for
example.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340.

@miniak miniak requested a review from electron/wg-security Jun 1, 2019

@miniak miniak self-assigned this Jun 1, 2019

@miniak miniak added the 4-2-x label Jun 1, 2019

@zcbenz

zcbenz approved these changes Jun 2, 2019

@zcbenz zcbenz merged commit 3d3d979 into 4-2-x Jun 4, 2019

11 of 14 checks passed

.github/main.workflow .github/main.workflow
Details
Valid Backport Invalid Backport
Details
Artifact Comparison
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190603.37 succeeded
Details
electron-arm64-testing Build #20190603.36 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340.

@zcbenz zcbenz deleted the miniak/backport-919340-4-2-x branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.