Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: throw error on invalid URLs when setting cookie #18756
Description of Change
With this PR, invalid inputs to the
Previously, invalid URLs would be able to be added as a cookie, but you would not be able to filter for them or remove them.
See Electron Fiddle gist: https://gist.github.com/d8ae35040d44d426cb40d97d5d77a47e
N.B. This behavior was fixed in Electron 6, so we based this PR a lot on the changes in the cookies API from 5.0.3 to 6.0.0-beta.
This issue was discovered when playing around with the example from #18220.
Notes: Added check for invalid URLs upon setting cookies
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.