fix: throw error on invalid URLs when setting cookie

[erickzhao]

Description of Change

With this PR, invalid inputs to the url parameter will throw an error when using cookie.set(). This is done by checking if the URL is parseable using GURL rather than checking if the URL string being passed in is empty.

Previously, invalid URLs would be able to be added as a cookie, but you would not be able to filter for them or remove them.

See Electron Fiddle gist: https://gist.github.com/d8ae35040d44d426cb40d97d5d77a47e

N.B. This behavior was fixed in Electron 6, so we based this PR a lot on the changes in the cookies API from 5.0.3 to 6.0.0-beta.

This issue was discovered when playing around with the example from #18220.

cc @deermichel @codebytere @ckerr

Checklist

• PR description included and stakeholders cc'd
• npm test passes(https://github.com/electron/electron/blob/master/docs/development/testing.md)
• relevant documentation is changed or added
• PR title follows semantic commit guidelines

Release Notes

Notes: Added check for invalid URLs upon setting cookies

[welcome]

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[deepak1556]

LGTM with minor change. Thanks!

[MarshallOfSound]

Temporarily requesting a hold while we figure out why the is_valid change blew up the test suite on master --> #18770 (review)

[release-clerk]

Release Notes Persisted

Added check for invalid URLs upon setting cookies

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[trop]

I was unable to backport this PR to "4-2-x" cleanly;
you will need to perform this backport manually.

[codebytere]

@erickzhao trop failed us here; can you open a manual bp to 4-2-x?

[trop]

A maintainer has manually backported this PR to "4-2-x", please check out #18911