Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTML fullscreen request for sub frames #18775

Conversation

@trop
Copy link
Contributor

commented Jun 13, 2019

Backport of #18736

See that PR for details.

Notes: fix exiting html fullscreen mode for embedded contents

fix: HTML fullscreen request for sub frames
Don't re-enter fullscreen if there is a pending operation,
for subframe fullscreen request `EnterFullScreenModeForTab`
will be called for both the frame in question as well as
the outer webContents hosting it.

@trop trop bot referenced this pull request Jun 13, 2019

Merged

fix: HTML fullscreen request for sub frames #18736

3 of 6 tasks complete

@trop trop bot added 6-0-x backport labels Jun 13, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 13, 2019

@codebytere codebytere merged commit 2401a2a into 6-0-x Jun 13, 2019

11 of 14 checks passed

build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190613.35 failed
Details
electron-arm64-testing Build #20190613.37 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 13, 2019

Release Notes Persisted

fix exiting html fullscreen mode for embedded contents

@codebytere codebytere deleted the trop/6-0-x-bp-fix-html-fullscreen-request-for-sub-frames-1560459794747 branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.