Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: callback values for printing cancellation and success #18803

Merged
merged 1 commit into from
Jun 17, 2019
Merged

fix: callback values for printing cancellation and success #18803

merged 1 commit into from
Jun 17, 2019

Conversation

codebytere
Copy link
Member

Backport of #17400.

See that PR for more details.

Notes: Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere requested a review from a team as a code owner June 14, 2019 18:36
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2019
@codebytere codebytere added 6-0-x backport This is a backport PR labels Jun 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2019
@codebytere codebytere requested a review from deepak1556 June 15, 2019 06:30
@codebytere codebytere merged commit 1527812 into 6-0-x Jun 17, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 17, 2019

Release Notes Persisted

Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere deleted the fix-printing-6-0-x branch June 17, 2019 18:33
@codebytere codebytere mentioned this pull request Jun 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @jkleinsc @zcbenz