Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callback values for printing cancellation and success #18803

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@codebytere
Copy link
Member

commented Jun 14, 2019

Backport of #17400.

See that PR for more details.

Notes: Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Jun 14, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Jun 14, 2019

@codebytere codebytere requested a review from deepak1556 Jun 15, 2019

@zcbenz

zcbenz approved these changes Jun 15, 2019

@codebytere codebytere merged commit 1527812 into 6-0-x Jun 17, 2019

11 of 14 checks passed

Valid Backport Invalid Backport
Details
electron-arm-testing Build #20190614.37 failed
Details
electron-arm64-testing Build #20190614.37 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 17, 2019

Release Notes Persisted

Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere deleted the fix-printing-6-0-x branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.