Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callback values for printing cancellation and success #18804

Merged
merged 1 commit into from Jun 15, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

commented Jun 14, 2019

Backport of #17400.

See that PR for more details.

Notes: Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere requested a review from deepak1556 Jun 14, 2019

@zcbenz

zcbenz approved these changes Jun 15, 2019

@zcbenz zcbenz merged commit 226dd75 into 5-0-x Jun 15, 2019

10 of 13 checks passed

Valid Backport Invalid Backport
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190614.40 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm64-testing Build #20190614.40 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jun 15, 2019

Release Notes Persisted

Fixed webContents.print() callback not returning boolean correctly in all cases.

@zcbenz zcbenz deleted the fix-printing-5-0-x branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.