Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show optional authors in gtk about panel #18964

Merged
merged 3 commits into from
Jun 25, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 24, 2019

Description of Change

Refs #2 in #18918.

This PR adds the ability to set a list of authors in the native Linux about panel.

I chose not to add this to the existing credits options owing to incompatible parameter types. We could potentially do it, but i felt that the added argument sanitization outweighed the benefit of being able to use a single argument across both platforms for this.

cc @ckerr @sindresorhus

Checklist

Release Notes

Notes: Added the ability to set authors in the Linux implementation of the About panel.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 24, 2019
@codebytere codebytere requested a review from ckerr June 24, 2019 18:34
ckerr
ckerr previously requested changes Jun 24, 2019
shell/browser/browser_linux.cc Outdated Show resolved Hide resolved
shell/browser/browser_linux.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the add-authors-about-panel-gtk branch 5 times, most recently from 496bb02 to 164e133 Compare June 24, 2019 20:59
@codebytere codebytere force-pushed the add-authors-about-panel-gtk branch from 164e133 to d44bda9 Compare June 24, 2019 21:19
@ckerr ckerr dismissed their stale review June 24, 2019 22:24

The changes I requested have been merged; but since I've also pushed code, I shouldn't be the one to approve

@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2019
@codebytere codebytere merged commit c87394e into master Jun 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 25, 2019

Release Notes Persisted

Added the ability to set authors in the Linux implementation of the About panel.

@codebytere codebytere deleted the add-authors-about-panel-gtk branch June 25, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants