Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show optional authors in gtk about panel #18964

Merged
merged 3 commits into from Jun 25, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Jun 24, 2019

Description of Change

Refs #2 in #18918.

This PR adds the ability to set a list of authors in the native Linux about panel.

I chose not to add this to the existing credits options owing to incompatible parameter types. We could potentially do it, but i felt that the added argument sanitization outweighed the benefit of being able to use a single argument across both platforms for this.

cc @ckerr @sindresorhus

Checklist

Release Notes

Notes: Added the ability to set authors in the Linux implementation of the About panel.

shell/browser/browser_linux.cc Outdated Show resolved Hide resolved
shell/browser/browser_linux.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the add-authors-about-panel-gtk branch 5 times, most recently from 496bb02 to 164e133 Jun 24, 2019
@codebytere codebytere force-pushed the add-authors-about-panel-gtk branch from 164e133 to d44bda9 Jun 24, 2019
@ckerr ckerr dismissed their stale review Jun 24, 2019

The changes I requested have been merged; but since I've also pushed code, I shouldn't be the one to approve

@codebytere codebytere removed the new-pr 🌱 label Jun 25, 2019
@codebytere codebytere merged commit c87394e into master Jun 25, 2019
12 of 13 checks passed
12 of 13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190624.33 succeeded
Details
electron-arm64-testing Build #20190624.33 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jun 25, 2019

Release Notes Persisted

Added the ability to set authors in the Linux implementation of the About panel.

@codebytere codebytere deleted the add-authors-about-panel-gtk branch Jun 25, 2019
@erickzhao erickzhao referenced this pull request Jul 24, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.