fix: ignore non-absolute session preload script paths when sandboxed #19066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/fix-session-preload-scripts
branch
from
13a86e7 to
d5b933d
Compare
miniak
force-pushed
the
miniak/fix-session-preload-scripts
branch
from
d5b933d to
d7ec8dc
Compare
zcbenz
approved these changes
Jul 3, 2019
jkleinsc
approved these changes
Jul 3, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Non-absolute session preload script paths were not ignored before for sandboxed renderers. This PR unifies the code to get the list of valid session preload scripts between sandboxed and non-sandboxed renderers.
Follow-up to #16538
Checklist
npm testpassesRelease Notes
Notes: Non-absolute session preload script paths are now ignored for sandboxed renderers.