Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore non-absolute session preload script paths when sandboxed #19066

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Jul 1, 2019

Description of Change

Non-absolute session preload script paths were not ignored before for sandboxed renderers. This PR unifies the code to get the list of valid session preload scripts between sandboxed and non-sandboxed renderers.

Follow-up to #16538

Checklist

Release Notes

Notes: Non-absolute session preload script paths are now ignored for sandboxed renderers.

@miniak miniak force-pushed the miniak/fix-session-preload-scripts branch from 13a86e7 to d5b933d Jul 1, 2019
@miniak miniak marked this pull request as ready for review Jul 1, 2019
@miniak miniak force-pushed the miniak/fix-session-preload-scripts branch from d5b933d to d7ec8dc Jul 1, 2019
@miniak miniak requested review from zcbenz, nornagon and MarshallOfSound Jul 1, 2019
@miniak miniak self-assigned this Jul 2, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 2, 2019
@zcbenz
zcbenz approved these changes Jul 3, 2019
@jkleinsc jkleinsc merged commit 69ea0b4 into master Jul 3, 2019
13 checks passed
13 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190701.37 succeeded
Details
electron-arm64-testing Build #20190701.39 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 3, 2019

Release Notes Persisted

Non-absolute session preload script paths are now ignored for sandboxed renderers.

@jkleinsc jkleinsc deleted the miniak/fix-session-preload-scripts branch Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.