Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dump correct breakpad symbols on macOS #19155

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@nornagon
Copy link
Contributor

commented Jul 8, 2019

Backport of #19042. See that PR for details.

Notes: Fixed macOS breakpad symbol files to include non-public symbols.

@trop trop bot referenced this pull request Jul 8, 2019

Merged

fix: dump correct breakpad symbols on macOS #19042

4 of 6 tasks complete

@nornagon nornagon added the 6-0-x label Jul 8, 2019

@zcbenz

zcbenz approved these changes Jul 9, 2019

@zcbenz zcbenz merged commit f5c3394 into 6-0-x Jul 9, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190708.19 succeeded
Details
electron-arm64-testing Build #20190708.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jul 9, 2019

Release Notes Persisted

Fixed macOS breakpad symbol files to include non-public symbols.

@zcbenz zcbenz deleted the backport/6-0-x/mac-dump-syms branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.